Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the diff for recent edits by replacing psDedent with ps #5574

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

hitesh-1997
Copy link
Contributor

@hitesh-1997 hitesh-1997 commented Sep 13, 2024

Context

psDedent removed the leading spaces making diff invalid. Replaced with ps

Test plan

  1. Manual testing by checking the diff validity

Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how to test this but the removal looks fine to me.

@hitesh-1997 hitesh-1997 merged commit 670e624 into main Sep 13, 2024
19 checks passed
@hitesh-1997 hitesh-1997 deleted the hitesh/fix-recent-edits-diff branch September 13, 2024 20:23
hitesh-1997 added a commit that referenced this pull request Sep 13, 2024
## Context
`psDedent` removed the spaces making diff invalid. Replaced with `ps`

## Test plan
1. Manual testing by checking the diff validity
hitesh-1997 added a commit that referenced this pull request Sep 16, 2024
## Cherry-pick
Autocomplete Logging: Fix the diff for recent edits by replacing
psDedent with ps to preserve the indentation.
[pull/5574](#5574)

## Test plan
version and changelog change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants